Polyfill: In Chinese calendar getMonthList, change check to assertion#3224
Merged
Polyfill: In Chinese calendar getMonthList, change check to assertion#3224
Conversation
This is only called on valid dates, so year should always be defined.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3224 +/- ##
==========================================
+ Coverage 96.75% 96.78% +0.02%
==========================================
Files 22 22
Lines 10398 10396 -2
Branches 1859 1858 -1
==========================================
+ Hits 10061 10062 +1
+ Misses 289 286 -3
Partials 48 48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ptomato
approved these changes
Jan 13, 2026
Collaborator
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
This one's a bit less straightforward to prove but I agree with you, I don't think I see any case where calendarYear could be undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only called on valid dates, so year should always be defined.